Skip to content

[WIP] Updating Paths and Path Assignment in Select Files #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[WIP] Updating Paths and Path Assignment in Select Files #177

wants to merge 9 commits into from

Conversation

@gwaybio
Copy link
Member

@gwaybio gwaybio commented Jun 7, 2019

This PR introduces two related changes introduced into a subset of the deepprofiler code base.

  1. Updating paths to include root path assignment
  • This update impacts __main__.py, boxes.py, and model.py
  1. Updating from hard path delimiter assignments to os.path.join
  • This update impacts __main__.py, boxes.py, image_dataset.py and model.py

I did not look into updating other scripts that were not touched by the following command:

python deepprofiler \
    --root=/Users/gway/repos/dp-test \
    --config=/Users/gway/repos/dp-test/inputs/config/config.json \
    train

Note that I am running the above command in the DeepProfiler repository directory.

@gwaybio
Copy link
Member Author

gwaybio commented Jun 7, 2019

cc @jccaicedo for review

@jccaicedo
Copy link
Member

This looks good to me. There is an issue with the Travis build, but it's unrelated to the changes in this PR, so we are good to go.

@jccaicedo
Copy link
Member

Actually, the errors are due to the changes in this PR. Can you run pytest and try to figure out the errors before merging?

Several tests break because of these updates. Also, make sure you pull the latest version, cause we fixed some tests recently.

@gwaybio
Copy link
Member Author

gwaybio commented Jul 30, 2019

Thanks @jccaicedo - working through this now. I am finding errors that indeed are breaking the tests!

Running through travis I did get an error. Documenting here:

tests/plugins/models/test_gan.py::test_train 
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
The build has been terminated

@gwaybio gwaybio changed the title Updating Paths and Path Assignment in Select Files [WIP] Updating Paths and Path Assignment in Select Files Jul 30, 2019
@Arkkienkeli Arkkienkeli force-pushed the master branch 2 times, most recently from 870f8ad to 0a4fdfe Compare September 24, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gwaybio @jccaicedo